> On Mar 9, 2016, at 1:39 AM, Alan Bateman <[email protected]> wrote: > > > > On 08/03/2016 23:00, Mandy Chung wrote: >>> On Mar 8, 2016, at 6:08 AM, Alan Bateman <[email protected]> wrote: >>> >>> In order, then my preferences for resolving this are: >>> >>> 1. Compete the tool separation, meaning JDK-8059035. >>> >>> 2. Change these tools to use services so that the SA backend is a service >>> provider. >>> >> #2 seems to be trivial and I quickly hack up a patch: >> http://cr.openjdk.java.net/~mchung/jigsaw/webrevs/8059035/webrev.00/ >> > Thanks for jumping on this, it looks good and very simple as you say. > > One thing that might need changes is the location of the tool provider, it's > currently sun.tools.providers and that seems too general. Shoudl we put this > to a spi package under jdk.internal for now?
I didn’t like the package name either but just get something to work. what about sun.tools.vm.spi? jdk.internal.vm.agent.spi (instead of jdk.internal.vm.spi which seems to be a generic VM SPI rather than specific to tools?) Mandy
