Please review the updated webrev @
http://cr.openjdk.java.net/~sundar/8136645/webrev.02/
* Changed "\n" to "\r\n"
* Removed POSIX/bits change code
Thanks,
-Sundar
On 4/1/2016 8:22 AM, Sundararajan Athijegannathan wrote:
> Hi,
>
> Comments below..
>
> On 4/1/2016 3:03 AM, Dmitry Samersoff wrote:
>> Sundararajan,
>>
>> Occasionally put my nose in. Just $0.2 ...
>>
>> 1. Do we really need separate .append("\n")? Also Windows convention is
>> "\r\n"
> I think so. Perhaps System.getProperty("line.separator") could be used.
> I'll fix it.
>
> Didn't realize it because cygwin is my development shell and did just
> "cat" on the generated file to view it :) Thanks!
>
>> 2. Is it possible to name a module using other languages (e.g. Russian
>> or Japanese). Is StandardCharsets.ISO_8859_1 appropriate in this case?
> Hmm.. This part remains the same as in Unix shell script generation
> (just above the newly added code). Not sure if that is practically a
> big issue...
>
>> 3. Is PosixFileAttributeView.class appropriate here? If yes - please add
>> a comment, because name is misleading.
> Changing executable bits on? I'll add comment.
>
> Thanks,
> -Sundar
>
>> -Dmitry
>>
>> On 2016-03-31 20:38, Sundararajan Athijegannathan wrote:
>>> Please review http://cr.openjdk.java.net/~sundar/8136645/webrev.00/ for
>>> https://bugs.openjdk.java.net/browse/JDK-8136645
>>>
>>> Thanks,
>>> -Sundar
>>>
