On 01/04/2016 09:38, Sundararajan Athijegannathan wrote:
Thanks for your comments.

* Removed !Files.exists
* Added isWindows check for .bat files

Updated webrev: http://cr.openjdk.java.net/~sundar/8136645/webrev.03/

This looks okay.

At some point then we need to change this so that it generates based on the target OS but it is a bit of a corner case to be generating a Windows runtime image when not on Windows. On the other hand, one might be creating a runtime image for an embedded system, say linux-arm, when on Windows, so that should work. We probably need other issues to track some of the residual issues to make that work.

-Alan

Reply via email to