I'm not an official reviewer but just a minor comment ...

I noticed that "executeTestJava" changed to "executeProcess" in ProxyTest.java, ProxyClassAccessTest.java and ModuleAccessControlTest.java, are these changes expected in this patch? If yes, should test/java/lang/reflect/Module/access/AccessTest.java also take similar change? AccessTest.java also uses "executeTestJava".

Thanks,
Amy


On 6/7/16 6:21 AM, Alexandre (Shura) Iline wrote:
Hi,

Please review the change with fixes the remaining @module declaration in 
java/lang tests:
http://cr.openjdk.java.net/~shurailine/8158855/webrev.00

This addresses everything in the java.lang, except next few tests which either 
require more work or blocked by other issues:
java/lang/SecurityManager/CheckSecurityProvider.java JDK-8158670
java/lang/String/concat/WithSecurityManager.java JDK-8158851
java/lang/management/MemoryMXBean/Pending.java JDK-8158837
java/lang/reflect/OldenCompilingWithDefaults.java CODETOOLS-7901694
java/lang/StackWalker/TestBCI.java, java/lang/invoke/lambda/LambdaAsm.java 
CODETOOLS-7901678


Shura


Reply via email to