On 07/06/2016 06:04, Alexandre (Shura) Iline wrote:
On Jun 6, 2016, at 8:59 PM, Amy Lu <amy...@oracle.com> wrote:
I'm not an official reviewer but just a minor comment ...
I noticed that "executeTestJava" changed to "executeProcess" in ProxyTest.java,
ProxyClassAccessTest.java and ModuleAccessControlTest.java, are these changes expected in this
patch?
Yes, the changes are expected.
These tests did not work with -limitmods java.base before because
executeTestJava(String…) adds the test java options to the executed java,
including the -limitmods.
This could be fixed differently, I have selected the easiest way: doing the
same as what executeTestJava(String …) does only without what
Utils.addTestJavaOpts(String…).
The @modules look okay but changing some of the executeTestJava usages
does look suspect. Should this be handled in ProcessTools instead?
-Alan
