Hi, Fixed as suggested: http://cr.openjdk.java.net/~sundar/8164800/webrev.02/
* Field name changed to targetOsName * Throwing RuntimeException if os name can't be determined from java.base -Sundar On 8/26/2016 7:30 PM, Alan Bateman wrote: > On 26/08/2016 14:51, Sundararajan Athijegannathan wrote: > >> Please review http://cr.openjdk.java.net/~sundar/8164800/webrev.01/ for >> https://bugs.openjdk.java.net/browse/JDK-8164800 >> >> > What would you think about rename osName to targetOsName to make it > clearer? > > Also in releaseProperties then I wonder if it should be an error if > java.base's osName returns null. If you don't agree then maybe it is > at least a warning. > > -Alan
