On 26/08/2016 15:54, Sundararajan Athijegannathan wrote:
Hi,

Fixed as suggested: http://cr.openjdk.java.net/~sundar/8164800/webrev.02/

* Field name changed to targetOsName

* Throwing RuntimeException if os name can't be determined from java.base


This looks okay except for RuntimeException, should this be PlugException with an appropriate cause? Also for the message then it would be better to say that the TargetPlatform attribute is missing from the java.base module.

-Alan

Reply via email to