> On Nov 1, 2016, at 2:44 PM, Steve Drach <steve.dr...@oracle.com> wrote: > > >>>> I’ve put out another webrev, >>>> http://cr.openjdk.java.net/~sdrach/8156499/webrev.05/, that addresses >>>> Mandy’s concerns. In particular I demonstrate that the resultant image is >>>> “runnable” and that a Main class in the image can/cannot find the >>>> java.logging module when the module-info.class is changed to require >>>> java.logging in one case but not in the other. >>> >>> Looks okay in general. The jlink change looks correct. Thanks for >>> updating the test. >> >> In fact - does this test run on windows? >> >> 239 Path java = Paths.get(image, "bin", "java”); >> >> On windows, shouldn’t this need to be “java.exe”? > > It turns out it runs just fine on the jprt windows test.
Thanks. So good to go. Mandy
