The hotspot part looks good to me.
Some copyright comments need update:
http://cr.openjdk.java.net/~alanb/8177530/1/hotspot/src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.test/src/org/graalvm/compiler/test/ExportingClassLoader.java.frames.html
http://cr.openjdk.java.net/~alanb/8177530/1/hotspot/src/share/vm/oops/klass.cpp.frames.html
http://cr.openjdk.java.net/~alanb/8177530/1/hotspot/src/share/vm/prims/jvmtiEnv.cpp.frames.html
One question:
http://cr.openjdk.java.net/~alanb/8177530/1/hotspot/src/share/vm/prims/jvmtiEnv.cpp.udiff.html
+// module - pre-checked for NULL
+// is_modifiable_class_ptr - pre-checked for NULL
+jvmtiError
+JvmtiEnv::IsModifiableModule(jobject module, jboolean*
is_modifiable_module_ptr) {
+ JavaThread* THREAD = JavaThread::current();
+
+ // check module
+ Handle h_module(THREAD, JNIHandles::resolve(module));
+ if (!java_lang_Module::is_instance(h_module())) {
+ return JVMTI_ERROR_INVALID_MODULE;
+ }
+
+ *is_modifiable_module_ptr = JNI_TRUE;
+ return JVMTI_ERROR_NONE;
+} /* end IsModifiableModule */
+ It seems, all the modules are modifiable at this point. Is it right?
Thanks,
Serguei
On 4/4/17 09:28, Alan Bateman wrote:
As I mentioned on jigsaw-dev yesterday, we have accumulated a number
of changes in the jake forest and would like to bring the changes into
jdk9/dev for jdk-9+165.
Most of the changes in this update are the move of Module and friends
from java.lang.reflect to java.lang. This is mostly a mechanical update.
We also have the update to the derivation of automatic modules to no
longer ignore trailing digits in modules names, this is to align JDK 9
with the updated proposal for issue #VersionsInModuleNames [1].
There are a number of smaller changes, summarized in JDK-8177530 [2].
The webrev with the changes is here:
http://cr.openjdk.java.net/~alanb/8177530/1
The changes are currently based on jdk-9+163 and will be rebased
before pushing to jdk9/dev.
The corresponding update to jtreg is already in the code-tools/jtreg
repo and will be tagged (I assume as jtreg4.2-b07) before this
integration. Once it is tagged then we'll rev'ing the requiredVersion
in each TEST.ROOT.
-Alan
[1]
http://openjdk.java.net/projects/jigsaw/spec/issues/#VersionsInModuleNames
[2] https://bugs.openjdk.java.net/browse/JDK-8177530
