>
> On Apr 4, 2017, at 9:28 AM, Alan Bateman <alan.bate...@oracle.com> wrote:
>
> The webrev with the changes is here:
> http://cr.openjdk.java.net/~alanb/8177530/1
>
I reviewed all changes. Looks good in general with a few minor comments:
Resolver.java
221 String prefix;
222 if (mref.descriptor().isAutomatic()) {
223 prefix = "Automatic module";
224 } else {
225 prefix = "Module";
226 }
It may be nice for this tracing output to follow similar format as to
—-list-module output (e.g “automatic” following the name/location)
java/util/ServiceLoader.java
216 * <p> Service loaders created to locate providers in a {@linkplain module
layer}
LauncherHelper.java
996 .ifPresent(any -> ostream.print(" automatic"));
It might be useful to indicate if the required module is not observable.
InstrumentationImpl.java
I think redefineModule should check isModifiableModule even the current
implementation returns true for all modules.
Mandy
