On 12 May 2017 at 11:22, Alan Bateman <[email protected]> wrote:
> However for #3 then you've
> missed several important error cases, e.g. illegal package names, or the
> package is already in another module defined to the class loader.
These checks are already present in implAddPackage, so why duplicate
those checks in the wrapping method?
Speaking of, the package name check in implAddPackage seems
incomplete. addPackage("some...pkg") would pass the check, but it's
shouldn't be legal, as it contains empty segments.
/Michael
