On 23/10/2017 06:37, Sundararajan Athijegannathan wrote:
Please review.

Bug: https://bugs.openjdk.java.net/browse/JDK-8189777
Webrev: http://cr.openjdk.java.net/~sundar/8189777/webrev.00/
This patch is very welcome as it makes jlink easier to use without any impact to the cross building case.

Two small comments:

- getStandardModulePath might be better renamed getDefaultModulePath as it isn't standard.

- JlinkConfiguration calls moduleFinder() during construction. You can avoid this by adding a static ModuelFinder moduleFinder(List<Path>).

-Alan

Reply via email to