On 25/10/2017 11:23, Sundararajan Athijegannathan wrote:
Updated: http://cr.openjdk.java.net/~sundar/8189777/webrev.03/
This looks better. A few comments/questions:
Does the JlinkConfiguration constructor that takes the ModuleFinder still need the module path? I assume it shouldn't be needed now (getModulepaths() seems unused). Also is the second constructor needed? I ask because the second constructor as it callbacks back to JlinkTask which seems a bit odd.
Is JlinkConfiguration the right place for getDefaultModulePath? It might be clearer to do that in JlinkTask.
-Alan
