Hi,

On 02/09/2018 04:23 PM, Michal Vala wrote:
Hi,

sending fix for jimage bug JDK-8170114[1].

as this was resolved with current behavior is correct[1], I've updated test case according to this behavior. Patch attached. This also greens JImageExtractTest so I've removed it from ProblemList.

[1] - https://bugs.openjdk.java.net/browse/JDK-8170114?focusedCommentId=14157816&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14157816

--
Michal Vala
OpenJDK QE
Red Hat Czech
--- old/test/jdk/ProblemList.txt	2018-02-19 14:59:41.645575388 +0100
+++ new/test/jdk/ProblemList.txt	2018-02-19 14:59:41.342574590 +0100
@@ -464,7 +464,6 @@
 
 tools/launcher/FXLauncherTest.java                              8068049 linux-all,macosx-all
 
-tools/jimage/JImageExtractTest.java                             8170120 generic-all
 tools/jimage/JImageListTest.java                                8170120 generic-all
 
 ############################################################################
--- old/test/jdk/tools/jimage/JImageExtractTest.java	2018-02-19 14:59:42.387577342 +0100
+++ new/test/jdk/tools/jimage/JImageExtractTest.java	2018-02-19 14:59:42.067576499 +0100
@@ -154,8 +154,10 @@
         Path tmp = Files.createTempDirectory(Paths.get("."), getClass().getName());
         Files.createFile(Paths.get(tmp.toString(), ".not_empty"));
         jimage("extract", "--dir", tmp.toString(), getImagePath())
-                .assertFailure()
-                .assertShowsError();
+                .assertSuccess()
+                .resultChecker(r -> {
+                    assertTrue(r.output.isEmpty(), "Output is not expected");
+                });
     }
 
     public void testExtractToFile() throws IOException {

Reply via email to