Hi Mandy, On Wed, 2019-02-13 at 15:04 -0800, Mandy Chung wrote: > Hi Severin, > > Thanks for doing this. I review the webrev.
Here is the latest webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8218913/02/webrev/ It uses --strip-java-debug-attributes as discussed in [1]. The --list- plugins output for --strip-debug and --strip-java-debug-attributes reads as follows: Plugin Name: strip-debug Option: --strip-debug Description: Strip debug information from the output image Plugin Name: strip-java-debug-attributes Option: --strip-java-debug-attributes Description: Strip Java debug attributes from classes in the output image Testing: test/jdk/tools/jlink and jdk/submit. Thoughts? Thanks, Severin [1] http://mail.openjdk.java.net/pipermail/jigsaw-dev/2019-February/014152.html > You add a new DefaultStripDebugPlugin that will do the work. > I have been assuming that this can be implemented as a jlink option > that get translated into --strip-java-debug-symbols during > the command line argument processing. > > I'm okay with --strip-java-debug-symbols. The help message from > javac -g option: > -g Generate all debugging info > > The other choice is --strip-java-debug-info and > --strip-native-debug-info. We can settle the naming in the other > thread > to get others > opinion. > > Mandy > > On 2/13/19 3:16 AM, Severin Gehwolf wrote: > > Hi, > > > > As discussed in the RFR thread for JDK-8214796 it was suggested to > > rename the --strip-debug plugin so that --strip-debug could > > actually > > perform java debug symbols stripping *and* native debug symbols > > stripping at once. That's what this patch does. It renames --strip- > > debug to --strip-java-debug-symbols and --strip-debug just calls -- > > strip-java-debug-symbols behind the scenes. > > > > Note that --strip-debug-attributes as name would work for me too, > > but > > given that we are about to introduce --strip-native-debug-symbols, > > having the java strippping plugin with a similar name made sense to > > me. > > > > bug: https://bugs.openjdk.java.net/browse/JDK-8218913 > > webrev: > > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8218913/01/webrev/ > > > > Testing: jlink/jimage tests and jdk/submit (currently running). > > > > Thoughts? > > > > Thanks, > > Severin > >
