On 2019-02-18 12:02, Severin Gehwolf wrote:
Hi Magnus,
On Mon, 2019-02-18 at 09:32 +0100, Magnus Ihse Bursie wrote:
15 feb. 2019 kl. 18:01 skrev Severin Gehwolf <sgehw...@redhat.com>:
Hi Alan, Mandy,
Here is the next round of this change:
http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8214796/06/webrev/
Looks good from the build PoV, with one minor nit: In
JtregNativeJdk.gmk, please use the new construct:
ifeq ($(call isTargetOs, linux), true)
Right. Thanks for this. I've updated it locally. The hunk in
JtregNaitveJdk.gmk now reads:
diff --git a/make/test/JtregNativeJdk.gmk b/make/test/JtregNativeJdk.gmk
--- a/make/test/JtregNativeJdk.gmk
+++ b/make/test/JtregNativeJdk.gmk
@@ -82,6 +82,14 @@
BUILD_JDK_JTREG_EXCLUDE += exeJniInvocationTest.c
endif
+ifeq ($(call isTargetOs, linux), true)
+ # Unconditionally compile with debug symbols and don't ever perform
+ # stripping during the test libraries' build.
+ BUILD_JDK_JTREG_LIBRARIES_CFLAGS_libFib := -g
+ BUILD_JDK_JTREG_LIBRARIES_STRIP_SYMBOLS_libFib := false
+endif
+
+
$(eval $(call SetupTestFilesCompilation, BUILD_JDK_JTREG_LIBRARIES, \
TYPE := LIBRARY, \
SOURCE_DIRS := $(BUILD_JDK_JTREG_NATIVE_SRC), \
Thanks,
Severin
+1
/Magnus
