Hi Claes, > fun little micro-optimization. :-)
Yep, I got a bit obsessed here. π But thanks for the review. > My only nit is that I'd have preferred if you kept the indentation > style, since the patch now shifts code around a bit (which makes it > harder to review and see the history) OK, I created an edition which doesn't change the formatting so that the added code becomes more obvious: http://cr.openjdk.java.net/~clanger/webrevs/8242039.1/ Does it look better? Cheers Christoph > > /Claes > > > On 2020-04-02 17:01, Langer, Christoph wrote: > > Hi, > > > > please review a small improvement for the jlink VersionPropsPlugin. The > Plugin modifies the bytecode of java/lang/VersionProps.class to replace the > initializion of certain vendor specific system properties with custom values. > This modification currently adds two bytecodes per constant, a pop and > another ldc. I overhauled it to simply replace the original ldc of the old > value > with another ldc, loading the custom value. > > > > I was playing a bit with the plugin and tried to familiarize with the code > > β so > thatβs the outcome π > > > > I also added an @SuppressWarnings("unused") in > VersionProps.java.template to quiesce an IDE warning. > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8242039 > > Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8242039.0/ > > > > Thanks > > Christoph > >
