Hi Claes and Mark, thanks again for your inputs.
I'll push this with Claes' review then. Best regards Christoph > -----Original Message----- > From: core-libs-dev <core-libs-dev-boun...@openjdk.java.net> On Behalf > Of Claes Redestad > Sent: Mittwoch, 8. April 2020 00:12 > To: core-libs-...@openjdk.java.net > Subject: Re: RFR: 8242039: Improve jlink VersionPropsPlugin > > > > On 2020-04-03 15:36, Langer, Christoph wrote: > > Eventually I came up with this result and then I also asked myself the > question whether the new complexity was worth the benefit. I answered > myself with a yes (though definitely not a clear one 😉), and that's why I > proposed the change. After all, the new complexity isn't huge... > > I don't mind the cleaned up patch[1]. > > It also gets rid of the constants being replaced, which I assume will > otherwise be loaded and kept on the heap and in the string table > forever. While unlikely to cause confusion, I'd argue that not finding > the value replaced in heap dumps might be of some value. > > /Claes > > [1] http://cr.openjdk.java.net/~clanger/webrevs/8242039.1/
