[
https://issues.apache.org/jira/browse/ARROW-10503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17226858#comment-17226858
]
Antoine Pitrou commented on ARROW-10503:
----------------------------------------
You can definitely submit a PR. Does it have to check the compiler version? I
would also suggest reporting the issue upstream.
> Uriparser will not compile using Intel compiler
> -----------------------------------------------
>
> Key: ARROW-10503
> URL: https://issues.apache.org/jira/browse/ARROW-10503
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
> Affects Versions: 2.0.0
> Environment: SUSE Linux Enterprise Server 12 SP3 with Intel Compiler
> Stack
> Reporter: Jensen Richardson
> Priority: Major
> Labels: pull-request-available
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> Fix for the Uriparser header file. The macro "URI_INLINE" was defined to
> "__force_inline", however the intel compiler keyword is now "__forceinline".
> Because of this change, the Intel compiler was no longer recognizing the
> keyword, which caused the whole build to fail. The patch is just changing
> this one line in the UriDefsConfig.h file from
> {code:cpp}
> # define URI_INLINE __force_inline
> {code}
> to
> {code:cpp}
> # define URI_INLINE __forceinline
> {code}
> The source for the new key word can be found
> [here|https://software.intel.com/content/www/us/en/develop/documentation/cpp-compiler-developer-guide-and-reference/top/compiler-reference/compiler-options/compiler-option-details/inlining-options/inline-forceinline-qinline-forceinline.html].
> I have a fork ready to make a pull request.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
