[ 
https://issues.apache.org/jira/browse/ARROW-10503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17226873#comment-17226873
 ] 

Jensen Richardson commented on ARROW-10503:
-------------------------------------------

I already reported it to the Uriparser team. Unfortunately, I don't have the 
documentation for the compilers older than 19, but my stack is built on 18 (the 
version denotes the year for the Intel compilers) and it still worked. I think 
it is unlikely enough that people are using version older than 18, so I feel 
comfortable enough not checking, and I wouldn't even know where the cutoff for 
using the old syntax would be because they don't say online. Frankly, the Intel 
historical documentation is terrible, and I'm unable to find anything online 
for any version older than the newest.

> Uriparser will not compile using Intel compiler
> -----------------------------------------------
>
>                 Key: ARROW-10503
>                 URL: https://issues.apache.org/jira/browse/ARROW-10503
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: C++
>    Affects Versions: 2.0.0
>         Environment: SUSE Linux Enterprise Server 12 SP3 with Intel Compiler 
> Stack
>            Reporter: Jensen Richardson
>            Priority: Major
>              Labels: pull-request-available
>   Original Estimate: 5m
>  Remaining Estimate: 5m
>
> Fix for the Uriparser header file. The macro "URI_INLINE" was defined to 
> "__force_inline", however the intel compiler keyword is now "__forceinline". 
> Because of this change, the Intel compiler was no longer recognizing the 
> keyword, which caused the whole build to fail. The patch is just changing 
> this one line in the UriDefsConfig.h file from
> {code:cpp}
> # define URI_INLINE __force_inline
> {code}
> to
> {code:cpp}
> # define URI_INLINE __forceinline
> {code}
> The source for the new key word can be found 
> [here|https://software.intel.com/content/www/us/en/develop/documentation/cpp-compiler-developer-guide-and-reference/top/compiler-reference/compiler-options/compiler-option-details/inlining-options/inline-forceinline-qinline-forceinline.html].
> I have a fork ready to make a pull request.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to