[ 
https://issues.apache.org/jira/browse/ARROW-13546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405258#comment-17405258
 ] 

Joris Van den Bossche commented on ARROW-13546:
-----------------------------------------------

[~maartenbreddels] sorry, missed this report. Do you still have a reference to 
the full traceback? (I don't see it in CI on the PR you mention ..)

I don't fully understand how we didn't catch this or how it's failing. A quick 
try to reproduce it:

{code}
In [1]: import fsspec

In [2]: localfs = fsspec.filesystem("file")

In [3]: from pyarrow.fs import PyFileSystem, FSSpecHandler

In [4]: fs = PyFileSystem(FSSpecHandler(localfs))

In [5]: with fs.open_output_stream("test"):
   ...:     pass
   ...: 
{code}

that seems to work fine.

> [Python] Breaking API change in FSSpecHandler, requires metadata argument
> -------------------------------------------------------------------------
>
>                 Key: ARROW-13546
>                 URL: https://issues.apache.org/jira/browse/ARROW-13546
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: Python
>            Reporter: Maarten Breddels
>            Priority: Major
>
> [https://github.com/apache/arrow/pull/10295] introduced the required metadata 
> argument to FSSpecHandler.open_output_stream 
> Noticed this in our CI/testsuite at 
> [https://github.com/vaexio/vaex/pull/1490] 
> {code:java}
>     def create():
> 261>       return fs.open_output_stream(path)
> 262E       TypeError: open_output_stream() missing 1 required positional 
> argument: 'metadata'
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to