[ 
https://issues.apache.org/jira/browse/ARROW-13546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405265#comment-17405265
 ] 

Joris Van den Bossche commented on ARROW-13546:
-----------------------------------------------

Ah, it might be possible that you are directly using the handler, instead of 
the handler wrapped in a PyFileSystem ? 
I don't think we considered that use case (or want to support it; although what 
you report is also a change for people implementing their own handler of course)

Looking at 
https://github.com/vaexio/vaex/blob/94c08b8337bc946a3c9b97f277ab23c5a931ed7d/packages/vaex-core/vaex/file/__init__.py#L200-L210,
 you have {{for_arrow=False}} keyword, and in that case don't wrap it in a 
PyFileSystem. What's the use for that keyword exactly? (and for using the 
handler directly?)

> [Python] Breaking API change in FSSpecHandler, requires metadata argument
> -------------------------------------------------------------------------
>
>                 Key: ARROW-13546
>                 URL: https://issues.apache.org/jira/browse/ARROW-13546
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: Python
>            Reporter: Maarten Breddels
>            Priority: Major
>
> [https://github.com/apache/arrow/pull/10295] introduced the required metadata 
> argument to FSSpecHandler.open_output_stream 
> Noticed this in our CI/testsuite at 
> [https://github.com/vaexio/vaex/pull/1490] 
> {code:java}
>     def create():
> 261>       return fs.open_output_stream(path)
> 262E       TypeError: open_output_stream() missing 1 required positional 
> argument: 'metadata'
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to