[
https://issues.apache.org/jira/browse/ARROW-15029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17468742#comment-17468742
]
Jeroen van Straten commented on ARROW-15029:
--------------------------------------------
I can pick this up as my first issue.
Looking at the code, if it's to be split up into 2-3 files of roughly equal
size it makes the most sense to me to split it up into
{{scalar_string_ascii.cc}} for ASCII/binary and {{scalar_string_utf8.cc}} for
UTF-8 strings, so that's what I've started doing now. Maybe someone has a
better idea, though?
> [C++] Split compute/kernels/scalar_string.cc
> --------------------------------------------
>
> Key: ARROW-15029
> URL: https://issues.apache.org/jira/browse/ARROW-15029
> Project: Apache Arrow
> Issue Type: Task
> Components: C++
> Reporter: Antoine Pitrou
> Priority: Minor
> Labels: good-first-issue, good-second-issue
>
> {{compute/kernels/scalar_string.cc}}, which defines scalar string kernels, is
> getting pretty large (and probably long-ish to compile). It would be nice to
> split it up thematically into 2 or 3 source files. Common utilities may be
> factored into a {{scalar_string_internal.h}} header, for example.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
