[ 
https://issues.apache.org/jira/browse/ARROW-15029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469307#comment-17469307
 ] 

Antoine Pitrou commented on ARROW-15029:
----------------------------------------

Yes, I don't think we'll find a meaningful splitting scheme that will result in 
two equal parts, so that sounds good enough. Feel free to submit a PR when 
you're finished with it :-)

> [C++] Split compute/kernels/scalar_string.cc
> --------------------------------------------
>
>                 Key: ARROW-15029
>                 URL: https://issues.apache.org/jira/browse/ARROW-15029
>             Project: Apache Arrow
>          Issue Type: Task
>          Components: C++
>            Reporter: Antoine Pitrou
>            Assignee: Jeroen van Straten
>            Priority: Minor
>              Labels: good-first-issue, good-second-issue
>
> {{compute/kernels/scalar_string.cc}}, which defines scalar string kernels, is 
> getting pretty large (and probably long-ish to compile). It would be nice to 
> split it up thematically into 2 or 3 source files. Common utilities may be 
> factored into a {{scalar_string_internal.h}} header, for example.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to