[ 
https://issues.apache.org/jira/browse/ARROW-15301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17472851#comment-17472851
 ] 

Dragoș Moldovan-Grünfeld commented on ARROW-15301:
--------------------------------------------------

I think having all custom helpers / functionality in one place would make it 
easier to say: "All custom functionality lives in this file".

> [R] Discussion: reorganise the testthat test helpers 
> -----------------------------------------------------
>
>                 Key: ARROW-15301
>                 URL: https://issues.apache.org/jira/browse/ARROW-15301
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: R
>            Reporter: Dragoș Moldovan-Grünfeld
>            Priority: Major
>             Fix For: 8.0.0
>
>
> Would it make sense to have all custom expectations in {{R/}} , maybe 
> {{R/test-helpers.R}} ? Reasons: * easier for newbies to read a file and 
> figure out what custom testthat helpers we have
>  * easier to document
>  * respects the testthat author's suggestion to have them there
> Currently we have 17 different custom expectations, all defined in different 
> files.
> A follow-up thought: maybe move all helpers there ({{{}is.{}}}, {{{}as_{}}}, 
> {{{}compare_{}}}, {{verify}} etc).



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to