[
https://issues.apache.org/jira/browse/ARROW-15301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17473124#comment-17473124
]
Dewey Dunnington commented on ARROW-15301:
------------------------------------------
Thank you for raising this issue...I found this particularly difficult about
the arrow R package tests, particularly when I first started working on them,
although it also comes up whenever I have to debug a new test failure (because
for most tests in arrow, you have to step through the whole file, as you noted).
If this is something that contributors are keen on, it may be worth considering
a "you touch it, you fix it" approach (as opposed to a reorganization). Or
maybe...new tests should be self-contained to the greatest extent possible?
Those approaches wouldn't require new work and we might realize as we're
writing new tests that we really do need the helpers. Just a few thoughts!
> [R] Discussion: reorganise the testthat test helpers
> -----------------------------------------------------
>
> Key: ARROW-15301
> URL: https://issues.apache.org/jira/browse/ARROW-15301
> Project: Apache Arrow
> Issue Type: Improvement
> Components: R
> Reporter: Dragoș Moldovan-Grünfeld
> Priority: Major
> Fix For: 8.0.0
>
>
> Would it make sense to have all custom expectations in {{R/}} , maybe
> {{R/test-helpers.R}} ? Reasons: * easier for newbies to read a file and
> figure out what custom testthat helpers we have
> * easier to document
> * respects the testthat author's suggestion to have them there
> Currently we have 17 different custom expectations, all defined in different
> files.
> A follow-up thought: maybe move all helpers there ({{{}is.{}}}, {{{}as_{}}},
> {{{}compare_{}}}, {{verify}} etc).
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
