[
https://issues.apache.org/jira/browse/ARROW-16825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17565226#comment-17565226
]
David Dali Susanibar Arce edited comment on ARROW-16825 at 7/12/22 2:29 AM:
----------------------------------------------------------------------------
Hi [~kou] / [~lidavidm] / [~breun] base on current functionality current
git.properties is created at building time and added to the jar artifacts
containing commit metadata information.
A proposal could be rename file that contains metadata about commit: From:
git.properties To: gitarrowinfo.properties
Main reason: git.properties is a generic name that could be use for third party
libraries for a different purpose than inspect arrow metadata information (i.e:
[SpringBoot|https://docs.spring.io/spring-boot/docs/current/reference/html/application-properties.html#application-properties.core.spring.info.git.location]
git.properties configuration).
Current Arrow Java artifacts are using
[git-commit-id-maven-plugin|https://github.com/git-commit-id/git-commit-id-maven-plugin]
to generate a file {{./git.properties}} with commit metadata such as:
{code:java}
#Generated by Git-Commit-Id-Plugin
#Wed Jun 08 11:43:58 UTC 2022
git.build.user.email=
git.build.host=Mac-1654686060479.local
git.dirty=true
git.remote.origin.url=https\://github.com/apache/arrow
git.closest.tag.name=apache-arrow-8.0.0
git.commit.id.describe-short=apache-arrow-3.0.0-3327-dirty
[email protected]
git.commit.time=08.06.2022 @ 07\:51\:03 UTC
git.commit.message.full=ARROW-16785\: [Packaging][Linux] Add FindThrift.cmake
(\#13337)\n\nThis is a follow-up of ARROW-16721/\#13292.\n\nAuthored-by\: Sutou
Kouhei <[email protected]>\nSigned-off-by\:
KrisztiSz<[email protected]>
git.build.version=9.0.0.dev191
git.commit.message.short=ARROW-16785\: [Packaging][Linux] Add FindThrift.cmake
(\#13337)
git.commit.id.abbrev=5fe3a60
git.branch=5fe3a606f16b183cf706ae8d9a4adaff593c18a1
git.build.user.name=
git.closest.tag.commit.count=11694
git.commit.id.describe=apache-arrow-3.0.0-3327-g5fe3a60-dirty
git.commit.id=5fe3a606f16b183cf706ae8d9a4adaff593c18a1
git.tags=
git.build.time=08.06.2022 @ 11\:43\:58 UTC
git.commit.user.name=Sutou Kouhei{code}
Artifacts affected:
{code:java}
find . -name '*.jar' -exec sh -c 'for f; do jar -tf "$f" | grep
"gitarrowinfo.properties" | sed "s|^|$f,|"; done' sh {} +
./plasma/target/arrow-plasma-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties
./tools/target/arrow-tools-9.0.0-SNAPSHOT-jar-with-dependencies.jar,gitarrowinfo.properties
./tools/target/arrow-tools-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties
./memory/memory-unsafe/target/arrow-memory-unsafe-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties
./memory/memory-netty/target/arrow-memory-netty-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties
./memory/memory-core/target/arrow-memory-core-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties
./dataset/target/arrow-dataset-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties
./flight/flight-sql/target/flight-sql-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties
./flight/flight-integration-tests/target/flight-integration-tests-9.0.0-SNAPSHOT-jar-with-dependencies.jar,gitarrowinfo.properties
./flight/flight-integration-tests/target/flight-integration-tests-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties
./flight/flight-grpc/target/flight-grpc-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties
./flight/flight-core/target/flight-core-9.0.0-SNAPSHOT-jar-with-dependencies.jar,gitarrowinfo.properties
./flight/flight-core/target/flight-core-9.0.0-SNAPSHOT-shaded.jar,gitarrowinfo.properties
./flight/flight-core/target/flight-core-9.0.0-SNAPSHOT-shaded-ext.jar,gitarrowinfo.properties
./flight/flight-core/target/flight-core-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties
./adapter/jdbc/target/arrow-jdbc-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties
./adapter/avro/target/arrow-avro-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties
./adapter/orc/target/arrow-orc-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties
./algorithm/target/arrow-algorithm-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties
./compression/target/arrow-compression-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties
./format/target/arrow-format-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties
./gandiva/target/arrow-gandiva-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties
./performance/target/benchmarks.jar,gitarrowinfo.properties
./performance/target/arrow-performance-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties
./vector/target/arrow-vector-9.0.0-SNAPSHOT-shade-format-flatbuffers.jar,gitarrowinfo.properties
./vector/target/arrow-vector-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties
./c/target/arrow-c-data-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties {code}
Please let me know if this approach could be possible or not.
was (Author: dsusanibara):
Hi [~kou] / [~lidavidm] / [~breun] base on current functionality current
git.properties is created at building time and added to the jar artifacts
containing commit metadata information.
A proposal could be rename file that contains metadata about commit: From:
git.properties To: gitarrowinfo.properties
Main reason: git.properties is a generic name that could be use for third party
libraries for a different purpose than inspect arrow metadata information (i.e:
[SpringBoot|https://docs.spring.io/spring-boot/docs/current/reference/html/application-properties.html#application-properties.core.spring.info.git.location]
git.properties configuration).
Current Arrow Java artifacts are using
[git-commit-id-maven-plugin|https://github.com/git-commit-id/git-commit-id-maven-plugin]
to generate a file {{./git.properties}} with commit metadata such as:
{code:java}
#Generated by Git-Commit-Id-Plugin
#Wed Jun 08 11:43:58 UTC 2022
git.build.user.email=
git.build.host=Mac-1654686060479.local
git.dirty=true
git.remote.origin.url=https\://github.com/apache/arrow
git.closest.tag.name=apache-arrow-8.0.0
git.commit.id.describe-short=apache-arrow-3.0.0-3327-dirty
[email protected]
git.commit.time=08.06.2022 @ 07\:51\:03 UTC
git.commit.message.full=ARROW-16785\: [Packaging][Linux] Add FindThrift.cmake
(\#13337)\n\nThis is a follow-up of ARROW-16721/\#13292.\n\nAuthored-by\: Sutou
Kouhei <[email protected]>\nSigned-off-by\:
KrisztiSz<[email protected]>
git.build.version=9.0.0.dev191
git.commit.message.short=ARROW-16785\: [Packaging][Linux] Add FindThrift.cmake
(\#13337)
git.commit.id.abbrev=5fe3a60
git.branch=5fe3a606f16b183cf706ae8d9a4adaff593c18a1
git.build.user.name=
git.closest.tag.commit.count=11694
git.commit.id.describe=apache-arrow-3.0.0-3327-g5fe3a60-dirty
git.commit.id=5fe3a606f16b183cf706ae8d9a4adaff593c18a1
git.tags=
git.build.time=08.06.2022 @ 11\:43\:58 UTC
git.commit.user.name=Sutou Kouhei{code}
Artifacts affected:
{code:java}
find . -name '*.jar' -exec sh -c 'for f; do jar -tf "$f" | grep
"gitarrowinfo.properties" | sed "s|^|$f,|"; done' sh {} +
./plasma/target/arrow-plasma-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties
./tools/target/arrow-tools-9.0.0-SNAPSHOT-jar-with-dependencies.jar,gitarrowinfo.properties
./tools/target/arrow-tools-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties
./memory/memory-unsafe/target/arrow-memory-unsafe-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties
./memory/memory-netty/target/arrow-memory-netty-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties
./memory/memory-core/target/arrow-memory-core-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties
./dataset/target/arrow-dataset-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties
./flight/flight-sql/target/flight-sql-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties
./flight/flight-integration-tests/target/flight-integration-tests-9.0.0-SNAPSHOT-jar-with-dependencies.jar,gitarrowinfo.properties
./flight/flight-integration-tests/target/flight-integration-tests-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties
./flight/flight-grpc/target/flight-grpc-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties
./flight/flight-core/target/flight-core-9.0.0-SNAPSHOT-jar-with-dependencies.jar,gitarrowinfo.properties
./flight/flight-core/target/flight-core-9.0.0-SNAPSHOT-shaded.jar,gitarrowinfo.properties
./flight/flight-core/target/flight-core-9.0.0-SNAPSHOT-shaded-ext.jar,gitarrowinfo.properties
./flight/flight-core/target/flight-core-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties
./adapter/jdbc/target/arrow-jdbc-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties
./adapter/avro/target/arrow-avro-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties
./adapter/orc/target/arrow-orc-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties
./algorithm/target/arrow-algorithm-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties
./compression/target/arrow-compression-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties
./format/target/arrow-format-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties
./gandiva/target/arrow-gandiva-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties
./performance/target/benchmarks.jar,gitarrowinfo.properties
./performance/target/arrow-performance-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties
./vector/target/arrow-vector-9.0.0-SNAPSHOT-shade-format-flatbuffers.jar,gitarrowinfo.properties
./vector/target/arrow-vector-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties
./c/target/arrow-c-data-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties
{code}
Please let me know if this approach could be possible or not.
> Inclusion of a git.properties resource in Arrow JARs causes confusion in
> Spring Boot applications
> -------------------------------------------------------------------------------------------------
>
> Key: ARROW-16825
> URL: https://issues.apache.org/jira/browse/ARROW-16825
> Project: Apache Arrow
> Issue Type: Bug
> Components: Java
> Affects Versions: 8.0.0
> Reporter: Nils Breunese
> Assignee: David Dali Susanibar Arce
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> By default Spring Boot reads {{classpath:git.properties}} to get information
> about the Git repository of an application. However, Arrow JARs also include
> a resource called {{git.properties}}, and this can cause Spring Boot to read
> the information from one of the Arrow libraries instead of from the
> application. [This was reported to Spring Boot as an
> issue|https://github.com/spring-projects/spring-boot/issues/18137], but the
> Spring Boot developers say that they cannot automatically distinguish the
> application Git properties from {{git.properties}} resources from
> dependencies.
> Would you consider omitting {{git.properties}} from Arrow JARs in future
> releases or will Spring Boot users that (directly or indirectly) use Arrow
> need to work around this by letting {{git-commit-id-plugin}} generate the
> application Git properties in an alternative location and configuring Spring
> Boot to read the information from that alternative location
> ({{spring.info.git.location}})? Of course other libraries could also cause
> this issue, but Arrow is the first and only library that I've encountered so
> far that publishes JARs with a {{git.properties}} resource in them.
> It seems that the fact that Arrow JARs include {{git.properties}} resources
> also caused ARROW-6361.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
