[ 
https://issues.apache.org/jira/browse/ARROW-16825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17565288#comment-17565288
 ] 

Nils Breunese edited comment on ARROW-16825 at 7/12/22 6:18 AM:
----------------------------------------------------------------

Either removing or renaming the generated resource would solve the issue that I 
reported in this ticket.

If you decide on keeping it, I would suggest adding hyphens or underscores to 
the file name to make it easier to read, e.g. {{arrow-git.properties}}.


was (Author: breun):
Renaming the generated resource would solve the issue that I reported in this 
ticket.

I would suggest adding hyphens or underscores to the file name to make it 
easier to read, e.g. {{arrow-git.properties}}.

> Inclusion of a git.properties resource in Arrow JARs causes confusion in 
> Spring Boot applications
> -------------------------------------------------------------------------------------------------
>
>                 Key: ARROW-16825
>                 URL: https://issues.apache.org/jira/browse/ARROW-16825
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: Java
>    Affects Versions: 8.0.0
>            Reporter: Nils Breunese
>            Assignee: David Dali Susanibar Arce
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> By default Spring Boot reads {{classpath:git.properties}} to get information 
> about the Git repository of an application. However, Arrow JARs also include 
> a resource called {{git.properties}}, and this can cause Spring Boot to read 
> the information from one of the Arrow libraries instead of from the 
> application. [This was reported to Spring Boot as an 
> issue|https://github.com/spring-projects/spring-boot/issues/18137], but the 
> Spring Boot developers say that they cannot automatically distinguish the 
> application Git properties from {{git.properties}} resources from 
> dependencies.
> Would you consider omitting {{git.properties}} from Arrow JARs in future 
> releases or will Spring Boot users that (directly or indirectly) use Arrow 
> need to work around this by letting {{git-commit-id-plugin}} generate the 
> application Git properties in an alternative location and configuring Spring 
> Boot to read the information from that alternative location 
> ({{spring.info.git.location}})? Of course other libraries could also cause 
> this issue, but Arrow is the first and only library that I've encountered so 
> far that publishes JARs with a {{git.properties}} resource in them.
> It seems that the fact that Arrow JARs include {{git.properties}} resources 
> also caused ARROW-6361.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to