[
https://issues.apache.org/jira/browse/ARROW-17686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17604967#comment-17604967
]
Weston Pace commented on ARROW-17686:
-------------------------------------
On Linux I make sure to build (with tests on) with {{ARROW_LARGE_MEMORY_TESTS}}
set to OFF. Then I build a debug build {{CMAKE_BUILD_TYPE=Debug}}. Then, from
the cmake build directory I run...
{noformat}
valgrind --suppressions=../valgrind.supp --tool=memcheck --gen-suppressions=all
--num-callers=500 --leak-check=full --leak-check-heuristics=stdstring
--error-exitcode=1 ./debug/arrow-compute-asof-join-node-test
{noformat}
> [C++] AsofJoinBasicParams has no gtest printer defined, leading to valgrind
> errors
> ----------------------------------------------------------------------------------
>
> Key: ARROW-17686
> URL: https://issues.apache.org/jira/browse/ARROW-17686
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
> Reporter: Weston Pace
> Assignee: Percy Camilo Triveño Aucahuasi
> Priority: Major
>
> Valgrind is currently failing on arrow-compute-asof-join-node-test:
> https://dev.azure.com/ursacomputing/crossbow/_build/results?buildId=34147&view=logs&j=0da5d1d9-276d-5173-c4c4-9d4d4ed14fdb&t=d9b15392-e4ce-5e4c-0c8c-b69645229181&l=4118
> The issue appears to be that AsofJoinBasicParams has no gtest printer and so
> gtest is using the default universal-printer which doesn't really play well
> with valgrind. We should add a custom PrintTo method for AsofJoinBasicParams
> per:
> https://github.com/google/googletest/blob/main/googletest/include/gtest/gtest-printers.h
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
