[
https://issues.apache.org/jira/browse/ARROW-17686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17606237#comment-17606237
]
Percy Camilo Triveño Aucahuasi commented on ARROW-17686:
--------------------------------------------------------
Something worth to mention: I found why I was not able to reproduce this
before, it seems this error is more visible for older valgrind versions (e.g.
valgrind-3.13.0 on ubuntu 18.04), but if we use modern valgrind distribution we
don't get errors (e.g.
valgrind-3.18.1 on ubuntu 22.04).
Here below, we can see the errors (this is using a docker container with
arm64-ubuntu 18.04/valgrind 3.13.0)
The good thing about this is that is not necessary to use (and wait) archery
docker run; now is possible to isolate this issue by using a specific container
for the arm64 platform. It seems archery docker cannot build arm64 containers
(the default platform is amd64) and running amd64 containers on Darwin arm64 is
slow (is faster to run containers with the same platform: arm64)
{code:java}
==26724==
==26724== HEAP SUMMARY:
==26724== in use at exit: 640 bytes in 2 blocks
==26724== total heap usage: 7,462,346 allocs, 7,462,344 frees, 2,061,859,187
bytes allocated
==26724==
==26724== 640 bytes in 2 blocks are possibly lost in loss record 1 of 1
==26724== at 0x4847B0C: calloc (in
/usr/lib/valgrind/vgpreload_memcheck-arm64-linux.so)
==26724==
{
<insert_a_suppression_name_here>
Memcheck:Leak
match-leak-kinds: possible
fun:calloc
}
==26724== LEAK SUMMARY:
==26724== definitely lost: 0 bytes in 0 blocks
==26724== indirectly lost: 0 bytes in 0 blocks
==26724== possibly lost: 640 bytes in 2 blocks
==26724== still reachable: 0 bytes in 0 blocks
==26724== suppressed: 0 bytes in 0 blocks
==26724==
==26724== For counts of detected and suppressed errors, rerun with: -v
==26724== Use --track-origins=yes to see where uninitialised values come from
==26724== ERROR SUMMARY: 2113 errors from 5 contexts (suppressed: 0 from
0){code}
> [C++] AsofJoinBasicParams has no gtest printer defined, leading to valgrind
> errors
> ----------------------------------------------------------------------------------
>
> Key: ARROW-17686
> URL: https://issues.apache.org/jira/browse/ARROW-17686
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
> Reporter: Weston Pace
> Assignee: Percy Camilo Triveño Aucahuasi
> Priority: Major
> Attachments: valgrind.txt
>
>
> Valgrind is currently failing on arrow-compute-asof-join-node-test:
> https://dev.azure.com/ursacomputing/crossbow/_build/results?buildId=34147&view=logs&j=0da5d1d9-276d-5173-c4c4-9d4d4ed14fdb&t=d9b15392-e4ce-5e4c-0c8c-b69645229181&l=4118
> The issue appears to be that AsofJoinBasicParams has no gtest printer and so
> gtest is using the default universal-printer which doesn't really play well
> with valgrind. We should add a custom PrintTo method for AsofJoinBasicParams
> per:
> https://github.com/google/googletest/blob/main/googletest/include/gtest/gtest-printers.h
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
