[
https://issues.apache.org/jira/browse/ARROW-17016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17605763#comment-17605763
]
Alenka Frim commented on ARROW-17016:
-------------------------------------
The approach on how we use {{GTest}} in {{PyArrow C+{+}{+}}} needs a change.
Currently it depends on {{GTest}} being built from source with {{{}Arrow
C+{}}}. There are two approaches I see to change that:
* expect {{GTest}} to be installed with {{Arrow C++}} and use
{{find_package(GTest REQUIRED)}}
* require {{GTest}} as a test dependency for {{PyArrow C++}} separately
The first approach seems the best: {{PyArrow C+{+}{+}}} tests would be built if
{{ARROW_BUILD_TESTS=on}} and in that case {{GTest}} is installed. Then I would
try to use {{pytest}} to run the C+ tests. I do think I had some issues with
finding the package when doing the refactoring work and am not sure it will
work out of the box.
[~raulcd] thank you for helping me with brainstorming for ideas!
[~kou], [~apitrou] could I get your feedback on this?
> [C++][Python] Run Arrow Python C++ with pytest and make sure they are run by
> the CI
> -----------------------------------------------------------------------------------
>
> Key: ARROW-17016
> URL: https://issues.apache.org/jira/browse/ARROW-17016
> Project: Apache Arrow
> Issue Type: Sub-task
> Components: C++, Python
> Reporter: Alenka Frim
> Assignee: Alenka Frim
> Priority: Major
> Labels: pull-request-available
> Fix For: 10.0.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> After [https://github.com/apache/arrow/pull/13311] is merged{-}, the tests
> for C PyArrow should be moved to Cython and the documentation about running
> the tests with GTest should be removed.{-} we should:
> - try to run the tests from the pytest to make the whole process of code
> quality check simplified.
> - make sure the CI runs these PyArrow C++ test. Currently they are not being
> run on the CI due to all the builds having GTest not bundled, see:
> [https://arrow.apache.org/docs/dev/developers/python.html#testing-pyarrow-c]
> The migration of the tests to Cython has not proved as a good option as
> there are couple of tests that should stay in the C++, for example
> [TestMoves|https://github.com/apache/arrow/blob/master/python/pyarrow/src/python_test.cc#L48-L62]
> and similar. For this reason we will find some other solution to keep using
> GTest and run them with pytest, if possible.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
