[
https://issues.apache.org/jira/browse/ARROW-17016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17605990#comment-17605990
]
Kouhei Sutou commented on ARROW-17016:
--------------------------------------
Sorry, I'm not familiar with Cython. Could you explain the reason for the
following case? We can't write {{TestMoves}} family with Cython?
> there are couple of tests that should stay in the C++, for example
> {{TestMoves}} and similar.
In general, I don't want PyArrow C++ to have Arrow C++'s
{{ThirdpartyToolchain.cmake}} like feature to reduce maintenance cost.
Maintaining {{ThirdpartyToolchain.cmake}} is high cost for us... So I like the
"migrating PyArrow C++ tests from GTest based to pytest+Cython based" approach
if possible. If we can remove GTest dependency from PyArrow C++, PyArrow C++
depends on only our Arrow C++ related CMake packages.
Is {{TestMoves}} family only the blocker of the approach? Or are there more
blockers?
> [C++][Python] Run Arrow Python C++ with pytest and make sure they are run by
> the CI
> -----------------------------------------------------------------------------------
>
> Key: ARROW-17016
> URL: https://issues.apache.org/jira/browse/ARROW-17016
> Project: Apache Arrow
> Issue Type: Sub-task
> Components: C++, Python
> Reporter: Alenka Frim
> Assignee: Alenka Frim
> Priority: Major
> Labels: pull-request-available
> Fix For: 10.0.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> After [https://github.com/apache/arrow/pull/13311] is merged{-}, the tests
> for C PyArrow should be moved to Cython and the documentation about running
> the tests with GTest should be removed.{-} we should:
> - try to run the tests from the pytest to make the whole process of code
> quality check simplified.
> - make sure the CI runs these PyArrow C++ test. Currently they are not being
> run on the CI due to all the builds having GTest not bundled, see:
> [https://arrow.apache.org/docs/dev/developers/python.html#testing-pyarrow-c]
> The migration of the tests to Cython has not proved as a good option as
> there are couple of tests that should stay in the C++, for example
> [TestMoves|https://github.com/apache/arrow/blob/master/python/pyarrow/src/python_test.cc#L48-L62]
> and similar. For this reason we will find some other solution to keep using
> GTest and run them with pytest, if possible.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
