[
https://issues.apache.org/jira/browse/KAFKA-6298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16277310#comment-16277310
]
Ismael Juma commented on KAFKA-6298:
------------------------------------
A few comments:
- This is similar to KAFKA-4710 (i.e. broker logs have had the same issue for a
while)
- We don't include line numbers due to the performance impact (requires a full
stacktrace to be built pre Java 9) in our default log config for kafka (i.e.
config/log4j.properties), but we do include them in the test configs
- It would be good to fix both brokers and clients and [~hachikuji]'s proposed
solution sounds good. I think we should use the `LocationAwareLogger` API if
available, but fallback to `Logger` if not.
> Line numbers on log messages are incorrect
> ------------------------------------------
>
> Key: KAFKA-6298
> URL: https://issues.apache.org/jira/browse/KAFKA-6298
> Project: Kafka
> Issue Type: Bug
> Reporter: Colin P. McCabe
>
> The line numbers on log messages are all incorrect now.
> For example, AdminClient should have this log message on line 394:
> {code}
> 394 log.debug("Kafka admin client initialized")
> {code}
> But instead, it shows up as being on line 177:
> {code}
> [2017-12-01 15:42:18,710] DEBUG [AdminClient clientId=adminclient-1]
> Kafka admin client initialized
> (org.apache.kafka.clients.admin.KafkaAdminClient:177)
> {code}
> The line numbers appear to be coming from {{LogContext.java}}:
> {code}
> 174 @Override
> 175 public void debug(String message) {
> 176 if (logger.isDebugEnabled())
> 177 logger.debug(logPrefix + message);
> 178 }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
