[
https://issues.apache.org/jira/browse/KAFKA-6298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16286059#comment-16286059
]
ASF GitHub Bot commented on KAFKA-6298:
---------------------------------------
GitHub user mrnakumar opened a pull request:
https://github.com/apache/kafka/pull/4311
KAFKA-6298 - Line numbers on log messages are incorrect
Modified LogContext.KafkaLogger to add support for location aware logging.
If LocationAwareLogger is not available then fallback to the Logger.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mrnakumar/kafka
KAFKA-6298-LOCATION-AWARE-LOGGING
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/4311.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4311
----
commit a8900b147e01384eaab84974f4fc11b530ca5490
Author: Narendra kumar <narendraku...@fico.com>
Date: 2017-12-11T13:43:25Z
Added location awareness to LogContext.KafkaLogger
----
> Line numbers on log messages are incorrect
> ------------------------------------------
>
> Key: KAFKA-6298
> URL: https://issues.apache.org/jira/browse/KAFKA-6298
> Project: Kafka
> Issue Type: Bug
> Reporter: Colin P. McCabe
> Assignee: Narendra Kumar
>
> The line numbers on log messages are all incorrect now.
> For example, AdminClient should have this log message on line 394:
> {code}
> 394 log.debug("Kafka admin client initialized")
> {code}
> But instead, it shows up as being on line 177:
> {code}
> [2017-12-01 15:42:18,710] DEBUG [AdminClient clientId=adminclient-1]
> Kafka admin client initialized
> (org.apache.kafka.clients.admin.KafkaAdminClient:177)
> {code}
> The line numbers appear to be coming from {{LogContext.java}}:
> {code}
> 174 @Override
> 175 public void debug(String message) {
> 176 if (logger.isDebugEnabled())
> 177 logger.debug(logPrefix + message);
> 178 }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
