jnh5y commented on PR #12298: URL: https://github.com/apache/kafka/pull/12298#issuecomment-1160665948
> @jnh5y I do not completely understand what you mean by: > > > I tried to find a way to create a unit test for this change, but I wasn't able to do so quickly. > > I have the impression that the unit test coverage is sufficient in `AbstractCoordinator#testRejoinReason`. Hi @cadonna, good question! At the point when I said that, I hadn't seen `AbstractCoordinator#testRejoinReason`. I was looking for a test which would call `AbstractCoordinator.joinGroupIfNeeded` and pass in an exception which was too large. I'm not still seeing how to modify that particular test to pass in an arbitrary exception. That said, I'm happy with @dajac's solution to call `requestRejoin`. In the follow-up ticket, we could test that this function works as we expect. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
