dajac commented on PR #12298: URL: https://github.com/apache/kafka/pull/12298#issuecomment-1170147202
> > @jnh5y Yeah, you cannot rely on providing the error in the response in your case. Instead, you have to find a place where you can actually throw a custom exception. That could be with a custom assignor for instance. > > I'm still learning the Kafka codebase, is there an example of using a custom assignor that is easy to understand? Also, should we go to the trouble to test this particular code path or is it sufficient to verify that the `reason` is limited when the function setting it is called? (I can see either argument.) @jnh5y Personally, I am fine with the test that we have in this PR. https://issues.apache.org/jira/browse/KAFKA-14013 is the important missing part in my opinion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
