dongjinleekr commented on code in PR #10826:
URL: https://github.com/apache/kafka/pull/10826#discussion_r916969277
##########
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##########
@@ -59,7 +59,7 @@ class GroupMetadataManager(brokerId: Int,
time: Time,
metrics: Metrics) extends Logging with
KafkaMetricsGroup {
- private val compressionType: CompressionType =
CompressionType.forId(config.offsetsTopicCompressionCodec.codec)
+ private val compressionConfig: CompressionConfig =
CompressionConfig.of(CompressionType.forId(config.offsetsTopicCompressionCodec.codec)).build
Review Comment:
I think introducing a separate config for compression level is somewhat
overkill; so let's use the default compression level for the offset topic. (I
will update the KIP accordingly later.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
