[GitHub] [kafka] dongjinleekr commented on a diff in pull request #10826: KAFKA-7632: Support Compression Level

[GitBox]

dongjinleekr commented on code in PR #10826:
URL: https://github.com/apache/kafka/pull/10826#discussion_r917053574


##########
core/src/main/scala/kafka/log/UnifiedLog.scala:
##########
@@ -1131,19 +1130,19 @@ class UnifiedLog(@volatile var logStartOffset: Long,
       shallowMessageCount += 1
       validBytesCount += batchSize
 
-      val messageCodec = 
CompressionCodec.getCompressionCodec(batch.compressionType.id)
-      if (messageCodec != NoCompressionCodec)
-        sourceCodec = messageCodec
+      val messageCompressionType = batch.compressionType
+      if (messageCompressionType != CompressionType.NONE)
+        sourceType = messageCompressionType
     }
 
     // Apply broker-side compression if any
-    val targetCodec = 
BrokerCompressionCodec.getTargetCompressionCodec(config.compressionType, 
sourceCodec)
+    val targetConfig = config.compressionConfig(sourceType)

Review Comment:
   Oh yes, `LogConfing#compressionConfig` now does the thing:
   
   ```
   def compressionConfig(producerCompressionType: CompressionType): 
CompressionConfig = {
       compressionType match {
           case ProducerCompressionCodec.name => 
getCompressionConfig(producerCompressionType)
           case "uncompressed" => CompressionConfig.NONE
           case _ => 
getCompressionConfig(CompressionType.forName(compressionType))
       }
   }
   ```
   
   But I will double check the test cases.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org