yashmayya opened a new pull request, #12450:
URL: https://github.com/apache/kafka/pull/12450

   *More detailed description of your change,
   if necessary. The PR title and PR message become
   the squashed commit message, so use a separate
   comment to ping reviewers.*
   
   - https://issues.apache.org/jira/browse/KAFKA-13809 : The FileStream 
connectors don't propagate all connector configs to their tasks.
   - https://issues.apache.org/jira/browse/KAFKA-9228 : client overrides, 
converter configs, SMT configs may not be propagated to tasks on connector 
config updates. This isn't an issue for most connectors because connector 
configs are propagated to the tasks in the connector implementations. This 
isn't the case for the FileStream connectors, however. 
   - This PR updates the FileStream connectors to be in-line with how most 
other connectors generate task configs (which is a good thing because these 
connectors are intended to be example connector implementations), and also 
works around the bug from https://issues.apache.org/jira/browse/KAFKA-9228
   - Minor: Also update the inaccurate source and sink connector Javadocs to 
align with the 
[source](https://github.com/apache/kafka/blob/0c5f5a7f8b3628e991459ba9cff414c675676b8b/connect/file/src/main/java/org/apache/kafka/connect/file/FileStreamSourceTask.java#L39-L41)
 and 
[sink](https://github.com/apache/kafka/blob/0c5f5a7f8b3628e991459ba9cff414c675676b8b/connect/file/src/main/java/org/apache/kafka/connect/file/FileStreamSinkTask.java#L36-L38)
 task Javadocs
   
   *Summary of testing strategy (including rationale)
   for the feature or bug fix. Unit and/or integration
   tests are expected for any behaviour change and
   system tests should be considered for larger changes.*
   
   - Manually tested the sink and source connectors and ensured that updates to 
SMT configs are reflected without manually restarting the tasks.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to