C0urante commented on PR #12450: URL: https://github.com/apache/kafka/pull/12450#issuecomment-1198659548
Hi Yash! Thanks for the fix. It's been a long time coming that we patched the KAFKA-9228 gap with the file connectors. I'm wondering about some of the other changes, though. We use these connectors as examples for developers on our docs site, and the section at https://kafka.apache.org/32/documentation.html#connect_connectorexample includes several code snippets taken directly from them. Even though it's not strictly necessary to pull out the topic, filename, etc. in the `Connector` implementations and we get the same behavior (KAFKA-9228 notwithstanding) by passing the original properties through to tasks transparently, it does help illustrate how to implement a connector to unfamiliar developers. Could you take a look at the docs, and see if there's a way to address KAFKA-9228 (and, if you want, clean up the style of the connectors) and, at the same time, maintain the connectors' value as examples for developers? Feel free to tweak the docs in `docs/connect.html` if necessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
