cmccabe commented on code in PR #12455:
URL: https://github.com/apache/kafka/pull/12455#discussion_r932718283
##########
core/src/test/scala/integration/kafka/server/DynamicBrokerReconfigurationTest.scala:
##########
@@ -335,7 +361,7 @@ class DynamicBrokerReconfigurationTest extends
QuorumTestHarness with SaslSetup
@Test
def testKeyStoreAlter(): Unit = {
val topic2 = "testtopic2"
- TestUtils.createTopic(zkClient, topic2, numPartitions, replicationFactor =
numServers, servers)
+ TestUtils.createTopicWithAdmin(adminClients.head, topic2, servers,
numPartitions, replicationFactor = numServers)
Review Comment:
this should be `brokers`, not `servers`, right?
Also, can you add a comment referencing the JIRA for converting this test (I
think you said you made one for this)
Also for any other unconverted ones I guess
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
