cmccabe commented on code in PR #12455:
URL: https://github.com/apache/kafka/pull/12455#discussion_r932719870
##########
core/src/test/scala/integration/kafka/server/DynamicBrokerReconfigurationTest.scala:
##########
@@ -537,13 +564,23 @@ class DynamicBrokerReconfigurationTest extends
QuorumTestHarness with SaslSetup
stopAndVerifyProduceConsume(producerThread, consumerThread)
}
- @Test
- def testConsecutiveConfigChange(): Unit = {
+ @ParameterizedTest(name = TestInfoUtils.TestWithParameterizedQuorumName)
+ @ValueSource(strings = Array("zk", "kraft"))
+ def testConsecutiveConfigChange(quorum: String): Unit = {
val topic2 = "testtopic2"
val topicProps = new Properties
topicProps.put(KafkaConfig.MinInSyncReplicasProp, "2")
- TestUtils.createTopic(zkClient, topic2, 1, replicationFactor = numServers,
servers, topicProps)
- var log = servers.head.logManager.getLog(new TopicPartition(topic2,
0)).getOrElse(throw new IllegalStateException("Log not found"))
+ TestUtils.createTopicWithAdmin(adminClients.head, topic2, servers,
numPartitions = 1, replicationFactor = numServers, topicConfig = topicProps)
+
+ def getLogOrThrow(tp: TopicPartition): UnifiedLog = {
+ var (logOpt, found) = TestUtils.computeUntilTrue {
+ servers.head.logManager.getLog(tp)
Review Comment:
this should be `brokers` not `servers`, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
