cadonna commented on PR #12441:
URL: https://github.com/apache/kafka/pull/12441#issuecomment-1199112880
@divijvaidya Thank you for the updates!
I am afraid you did a mistake when generating the test reports to test the
changes. You changed task `integrationTest` and task `unitTest` but you
generated the reports with `streams:test`. In task `test` no filtering is done
on the tags `integration` and `org.apache.kafka.test.IntegrationTest`. Also the
builds use `integrationTest` and `unitTest` to run the tests and not `test`.
You should generate the reports with `streams:integrationTest` and
`streams:unitTest`.
In my tests yesterday, I experienced that you cannot use
`@Tags("integration")` (and filter on it) on integration tests that are written
JUnit 4, but you need to leave `@Category({IntegrationTest.class})` in the
tests and use `includeTags "org.apache.kafka.test.IntegrationTest"` in the
build file. For integration tests written in JUnit 5, you need to use
`@Tags("integration")` in the tests and `includeTags "integration"` in the
build file. See my comment
https://github.com/apache/kafka/pull/12441#discussion_r932429697.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
