[GitHub] [kafka] divijvaidya commented on pull request #12441: KAFKA-14108: Ensure both JUnit 4 and JUnit 5 tests run

[GitBox]

divijvaidya commented on PR #12441:
URL: https://github.com/apache/kafka/pull/12441#issuecomment-1199094555

   ## Changes
   1. Replace with `@Category({IntegrationTest.class})` with 
`@Tag("integration")` 
   2. Unblock `streams` project from using JUnitPlatform.
   3. Use `junit-vintage` and `junit-jupiter` engine for executing tests of 
`streams` project. Tests formatted as Junit4 will automatically use 
`junit-vintage` and tests formatted as JUnit5 will automatically use 
`junit-jupiter`.
   4. Minor change required in `KTableSourceTopicRestartIntegrationTest.java` 
after using `junit-jupiter`
   
   ## Results
   Result of executing `./gradlew :streams:test` before & after this change.
   
   ### Before
   <img width="1296" alt="Screenshot 2022-07-29 at 11 30 16" 
src="https://user-images.githubusercontent.com/71267/181733713-2dff4282-13b3-4359-96d3-7604cb501a59.png";>
   
   ### After 
   <img width="1286" alt="Screenshot 2022-07-29 at 11 20 44" 
src="https://user-images.githubusercontent.com/71267/181733751-5c86103a-146a-4b4d-8a58-0a77b2395abc.png";>
   
   Note that after this change we are running more number of tests. This is 
because tests which were migrated to JUnit 5 were not being executed earlier.
   
   ## Comments
   Addressed concerns from @ijuma:
   - regarding not affecting other projects with this change (note that 
`junit-vintage` is being used for streams only)
   - regarding removal of addition of unnecessary dependencies (removed the 
unnecessary dependency)
   
   Addressed concerns from @cadonna 
   - regarding adding `junitJupiterParams` dependency only when needed (removed 
the dependency)
   
   ## Next steps (separate PRs, in order)
   1. Migrate tests using PowerMock to use Mockito 
   2. Migrate all tests to Junit5
   3. Remove the Junit4 dependency completely from `build.gradle`
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org