C0urante commented on code in PR #12490:
URL: https://github.com/apache/kafka/pull/12490#discussion_r940409780
##########
connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java:
##########
@@ -853,6 +853,9 @@ private void processConnectorConfigRecord(String
connectorName, SchemaAndValue v
connectorConfigs.remove(connectorName);
connectorTaskCounts.remove(connectorName);
taskConfigs.keySet().removeIf(taskId ->
taskId.connector().equals(connectorName));
+ deferredTaskUpdates.remove(connectorName);
+ connectorTaskCountRecords.remove(connectorName);
Review Comment:
I think we could possibly keep the deletion logic for task config
generations, but we'd have to make the herder resilient against null values
being returned from `ClusterConfigState::taskConfigGeneration` in case a
connector is deleted while there's an ongoing round of zombie fencing. Up to
you if you'd like to tackle that, and if so, if you'd prefer to do that here or
in a follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
