C0urante commented on code in PR #12490:
URL: https://github.com/apache/kafka/pull/12490#discussion_r948191499
##########
connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java:
##########
@@ -853,6 +853,9 @@ private void processConnectorConfigRecord(String
connectorName, SchemaAndValue v
connectorConfigs.remove(connectorName);
connectorTaskCounts.remove(connectorName);
taskConfigs.keySet().removeIf(taskId ->
taskId.connector().equals(connectorName));
+ deferredTaskUpdates.remove(connectorName);
+ connectorTaskCountRecords.remove(connectorName);
Review Comment:
👍 happy to help!
RE testing: I wouldn't overthink it; you can just upgrade the visibility of
`deferredTaskUpdates` from private to package-private (possibly with a `//
visible for testing` comment above the field declaration) and then probe its
contents in the `KafkaConfigBackingStoreTest` suite, either within existing
tests or with a new test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
