dajac commented on code in PR #12501:
URL: https://github.com/apache/kafka/pull/12501#discussion_r944479620
##########
core/src/test/scala/integration/kafka/api/TransactionsExpirationTest.scala:
##########
@@ -105,6 +105,36 @@ class TransactionsExpirationTest extends
KafkaServerTestHarness {
}
}
+ @ParameterizedTest(name = TestInfoUtils.TestWithParameterizedQuorumName)
+ @ValueSource(strings = Array("zk", "kraft"))
+ def testTransactionAfterProducerIDExpires(quorum: String): Unit = {
Review Comment:
nit: `ID` -> `Id` to respect naming conventions.
##########
core/src/main/scala/kafka/server/KafkaConfig.scala:
##########
@@ -965,6 +968,10 @@ object KafkaConfig {
val TransactionsAbortTimedOutTransactionsIntervalMsDoc = "The interval at
which to rollback transactions that have timed out"
val TransactionsRemoveExpiredTransactionsIntervalMsDoc = "The interval at
which to remove transactions that have expired due to
<code>transactional.id.expiration.ms</code> passing"
+ val ProducerIdExpirationMsDoc = "The time in ms that a topic partition
leader will wait before expiring producer IDs. Producer IDs will not expire
while a transaction associated to them is still ongoing. " +
+ "Note that producer ids may expire sooner if the last write from the
producer id is deleted due to the topic's retention settings. Setting this
value the same or higher than " +
Review Comment:
nit: `ids` -> `IDs` and `id` -> `ID` to stay consistent with the first
sentence?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
