jolshan commented on PR #12501: URL: https://github.com/apache/kafka/pull/12501#issuecomment-1217219270
@ijuma @dajac With the way that the cleanup is hardcoded in LogManager object I can't really test the config correctly used in an e2e test. The config is passed into the same apply method as we use the hardcoded value. After that, the config values are pulled out. One option I can think of is changing the hard-coded value in LogManager to a parameter with the hardcoded value as the default. Of course -- having default values is not always the best design choice. Another option is to make the value configurable, but I don't know if we'd ever want to reconfigure this beyond test usage. (It is a bit undocumented that this value exists though -- people may be surprised to set the value below 10 min but not see expirations under that amount of time.) > Do we need a test that validates the producer id expiration without transactions? We have a test already for this (since the feature already existed -- was just using the transactional ID expiration value) in ProducerStateManager. If we want to get the whole e2e experience using the config, then we need to do what was mentioned above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
