clolov commented on code in PR #12492:
URL: https://github.com/apache/kafka/pull/12492#discussion_r947594751
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/HighAvailabilityStreamsPartitionAssignorTest.java:
##########
@@ -148,34 +155,27 @@ private void createMockTaskManager(final Set<TaskId>
activeTasks) {
}
private void createMockTaskManager(final Map<TaskId, Long> taskOffsetSums)
{
- taskManager = EasyMock.createNiceMock(TaskManager.class);
- expect(taskManager.topologyMetadata()).andStubReturn(topologyMetadata);
-
expect(taskManager.getTaskOffsetSums()).andReturn(taskOffsetSums).anyTimes();
Review Comment:
Yeah, after looking a bit more into this it just seems that this code path
is not exercised. I deleted it from the original EasyMock tests and the tests
still passed, so I think it was not exercised in the original test either. I
put a breakpoint in the beginning of the test and it was never reached.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
