Gerrrr commented on code in PR #12535:
URL: https://github.com/apache/kafka/pull/12535#discussion_r949396415
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionStoreReceiveProcessorSupplier.java:
##########
@@ -91,7 +91,7 @@ public void process(final Record<KO, SubscriptionWrapper<K>>
record) {
droppedRecordsSensor.record();
return;
}
- if (record.value().getVersion() !=
SubscriptionWrapper.CURRENT_VERSION) {
+ if (record.value().getVersion() >
SubscriptionWrapper.CURRENT_VERSION) {
Review Comment:
There is
https://github.com/apache/kafka/blob/2ff4c0a364379d231edfe1836042574359b1023e/streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionResolverJoinProcessorSupplier.java#L85-L91
I did not update it because the version check there is for
`SubscriptionResponseWrapper` and its version wasn't incremented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
